lkml.org 
[lkml]   [2010]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateMon, 29 Mar 2010 11:50:56 -0400
FromMasami Hiramatsu <>
SubjectRe: [PATCH] perf, probe-finder: Build fix on Debian
Borislav Petkov wrote:
> Building chokes with
>
> In file included from /usr/include/gelf.h:53,
> from /usr/include/elfutils/libdw.h:53,
> from util/probe-finder.h:61,
> from util/probe-finder.c:39:
> /usr/include/libelf.h:98: error: expected specifier-qualifier-list before 'off64_t'
> /usr/include/libelf.h:160: error: expected specifier-qualifier-list before 'off64_t'
> /usr/include/libelf.h:201: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'elf_update'
> /usr/include/libelf.h:207: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'elf_getbase'
> /usr/include/libelf.h:305: error: expected declaration specifiers or '...' before 'off64_t'
> /usr/include/libelf.h:317: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'elf_getaroff'
> make: *** [util/probe-finder.o] Error 1
> make: *** Waiting for unfinished jobs....
> rm .perf.dev.null
>
> which is due to the fact that </usr/include/libelf.h> isn't seeing
> off64_t from <sys/types.h>
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Thank you for fixing it :)

However, all library checking routine in Makefile use
"-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64", so I think
it is better to add these flags to ALL_CFLAGS.

Thank you,


> ---
>
> This happens on current -git: v2.6.34-rc2-288-gb72c409
>
> tools/perf/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 8a8f52d..19c34a5 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -508,7 +508,7 @@ ifneq ($(shell sh -c "(echo '\#include <dwarf.h>'; echo '\#include <libdw.h>'; e
> msg := $(warning No libdw.h found or old libdw.h found, disables dwarf support. Please install elfutils-devel/elfutils-dev);
> BASIC_CFLAGS += -DNO_DWARF_SUPPORT
> else
> - BASIC_CFLAGS += -I/usr/include/elfutils
> + BASIC_CFLAGS += -I/usr/include/elfutils -D_LARGEFILE64_SOURCE
> EXTLIBS += -lelf -ldw
> LIB_OBJS += util/probe-finder.o
> endif

--
Masami Hiramatsu
e-mail: mhiramat@redhat.com


\
 
 \ /
  Last update: 2010-03-29 17:53    [from the cache]
©2003-2010