lkml.org 
[lkml]   [2010]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] Make room for other tps6507x drivers to have board specific initialization data.
On Fri, Mar 26, 2010 at 02:11:29PM -0600, Todd Fischer wrote:
> Need mfd structure that can hold pointers to sub-driver initialization
> and run time data.

Please provide a more verbose changelog. What needs this structure?

> /**
> + * tps_board points to pmic related constants
> + * coming from the board-evm file.
> + */
> +
> + tps_board = (struct tps6507x_board *)client->dev.platform_data;

There's no need to cast away from void and you ought to be using
dev_get_platdata().

> + if (!tps_board)
> + return -EIO;
> +

This seems like the wrong error code to be using here.


\
 
 \ /
  Last update: 2010-03-29 14:57    [W:0.233 / U:0.536 seconds]
©2003-2014 Jasper Spaans. Advertise on this site