lkml.org 
[lkml]   [2010]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] create generic alignment api (v2)
* Imre Deak (imre.deak@nokia.com) wrote:
> On Sun, Mar 28, 2010 at 03:22:47AM +0200, ext Mathieu Desnoyers wrote:
> > [...]
> > +/**
> > + * offset_align - Calculate the offset needed to align an object on its natural
> > + * alignment towards higher addresses.
> > + * @align_drift: object offset from an "alignment"-aligned address.
> > + * @alignment: natural object alignment. Must be non-zero, power of 2.
> > + *
> > + * Returns the offset that must be added to align towards higher
> > + * addresses.
> > + */
> > +static inline size_t offset_align(size_t align_drift, size_t alignment)
> > +{
> > + return (alignment - align_drift) & (alignment - 1);
> > +}
> > +
> > +/**
> > + * offset_align_floor - Calculate the offset needed to align an object
> > + * on its natural alignment towards lower addresses.
> > + * @align_drift: object offset from an "alignment"-aligned address.
> > + * @alignment: natural object alignment. Must be non-zero, power of 2.
> > + *
> > + * Returns the offset that must be substracted to align towards lower addresses.
> > + */
> > +static inline size_t offset_align_floor(size_t align_drift, size_t alignment)
> > +{
> > + return (align_drift - alignment) & (alignment - 1);
> > +}
> > +
> > +#define object_align(object) \
> > + ((typeof(object))((size_t) object + offset_align((size_t) object, \
> > + sizeof(object))))
> > +
> > +#define object_align_floor(object) \
> > + ((typeof(object))((size_t) object - offset_align_floor((size_t) object,\
> > + sizeof(object))))
> > +
>
> Here object must be a pointer, but then sizeof(object) will result in
> aligning to the arch word size not the object's natural alignment. Is
> this what you intended?

Nope, should be sizeof(*object). Good catch. I did the object_align*() macros
specifically as "helper" functions for your needs.

I'll repost a v3.

Thanks,

Mathieu

>
> --Imre
>

--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com


\
 
 \ /
  Last update: 2010-03-28 20:31    [W:0.112 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site