Messages in this thread | | | Date | Sat, 27 Mar 2010 20:48:59 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH] rcu: make dead code really dead |
| |
On Sun, Mar 28, 2010 at 11:15:20AM +0800, Lai Jiangshan wrote: > > cleanup: make dead code really dead
Good catch! I have queued this one up for RCU for 2.6.35.
Thanx, Paul
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > --- > diff --git a/kernel/rcutree.c b/kernel/rcutree.c > index e6014e1..1947c4e 100644 > --- a/kernel/rcutree.c > +++ b/kernel/rcutree.c > @@ -1236,11 +1236,11 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed) > break; /* grace period idle or initializing, ignore. */ > > case RCU_SAVE_DYNTICK: > - > - raw_spin_unlock(&rnp->lock); /* irqs remain disabled */ > if (RCU_SIGNAL_INIT != RCU_SAVE_DYNTICK) > break; /* So gcc recognizes the dead code. */ > > + raw_spin_unlock(&rnp->lock); /* irqs remain disabled */ > + > /* Record dyntick-idle state. */ > force_qs_rnp(rsp, dyntick_save_progress_counter); > raw_spin_lock(&rnp->lock); /* irqs already disabled */ >
| |