lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Prevent nested interrupts when the IRQ stack is near overflowing v2
From
Date
Andi Kleen <andi@firstfloor.org> writes:

>> I think the patch as posted solves a real problem, but also perpetuates a bad
>> situation.
>>
>> At minimum we should print a (one-time) warning that some badness occured.
>> That would push us either in the direction of improving drivers, or towards
>> improving the generic code.
>
> What should a driver do to prevent that? I don't see what it could do
> short of castrating itself (like refusing to use multiple ports)
> As Linus says the driver doesn't know if setting IRQF_DISABLED is safe.

As an aside this is happening on MSI irqs. They can never be shared.
So in fact the driver can know it is safe.

Should we perhaps make all MSI irqs automatically set IRQF_DISABLED?

Eric


\
 
 \ /
  Last update: 2010-03-26 05:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site