lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:

> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> tools/perf/builtin-trace.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 407041d..3c699c5 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -59,9 +59,6 @@ static int cleanup_scripting(void)
> #include "perf.h"
> #include "util/debug.h"
>
> -#include "util/trace-event.h"
> -#include "util/exec_cmd.h"
> -
> static char const *input_name = "perf.data";
>
> static int process_sample_event(event_t *event, struct perf_session *session)

Please send a more complete patch that fixes the root cause of the
duplication: a few header files are in the middle of the .c file - all
inclusions should be at the top of the file.

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-03-26 09:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site