lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Protect prefetch macro arguments.


On Fri, 26 Mar 2010, David Daney wrote:

> On 03/26/2010 02:04 PM, Linus Torvalds wrote:
> >
> >
> > On Fri, 26 Mar 2010, David Daney wrote:
> > >
> > > The GCC built-in __builtin_prefetch() is a vargs function. If we
> > > don't wrap the macro parameter in parentheses, a comma operator in the
> > > actual argument list might cause unintended parameters to be passed to
> > > __builtin_prefetch().
> >
> > This seems totally pointless and actively wrong.
>
> Pointless, perhaps. But 'actively wrong'? Are you sure about that?

Yes, I'm sure about that.

Your commit message was actively misleading, and the end result is worse
than the original and shows a lack of understanding of the C preprocessor.

IOW, very much "actively wrong".

Linus


\
 
 \ /
  Last update: 2010-03-26 22:31    [W:0.043 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site