lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/6] hid: new driver for PicoLCD device
    On Fri, 26 Mar 2010, Bruno Prémont wrote:

    > > > + for (i = 0; i < PICOLCD_KEYS; i++) {
    > > > + int key = ((int *)idev->keycode)[i];
    > >
    > > Keycodes are now short, not int. Also, just do:
    > >
    > > input_set_capability(idev, EV_KEY, data->keycode[i]);
    > >
    > > > + if (key < KEY_MAX && key >= 0)
    > > > + input_set_capability(idev, EV_KEY, key);
    >
    > Oops, I was not careful enough when switching over...

    Dmitry, thanks a lot for rapid review the driver.

    Bruno, could you please fix this and submit a followup 1/6 patch, so that
    I could queue the driver in my tree?

    I have almost finished going over the driver and haven't encountered any
    other issues that would require immediate fixing.

    Still, it would be nice to have the framebuffer/LCD/backlight bits
    reviewed by respective subsystem maintainers. But I'll probably queue the
    driver nevertheless and add potential ACKs later.

    Thanks,

    --
    Jiri Kosina
    SUSE Labs, Novell Inc.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-26 22:01    [W:0.021 / U:150.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site