Messages in this thread | | | Date | Fri, 26 Mar 2010 15:26:26 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include |
| |
Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu: > KOSAKI Motohiro wrote: > >> Hi Andrea, > >> > >> Andrea Gelmini wrote: > >>> tools/perf/util/probe-finder.c: string.h is included more than once. > >> > >> Would you mean that <string.h> and "string.h" are duplicated? > >> If so, NAK, sorry. Those are different, <string.h> is for > >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. > >> > >> Thank you, > > > > I think this discussion suggested "string.h" should be renameed more review > > friendly name. probably.
String should be renamed, yes, I'll do that.
> Hmm, we'd better review files under tools/utils/include too. :( > (not sure why we have those files, because some files includes > headers from original include directory, as like as > "../../include/linux/blahblah.h")
To share code with the kernel (rbtree.[ch], list.h).
- Arnaldo
| |