lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu:
> KOSAKI Motohiro wrote:
> >> Hi Andrea,
> >>
> >> Andrea Gelmini wrote:
> >>> tools/perf/util/probe-finder.c: string.h is included more than once.
> >>
> >> Would you mean that <string.h> and "string.h" are duplicated?
> >> If so, NAK, sorry. Those are different, <string.h> is for
> >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
> >>
> >> Thank you,
> >
> > I think this discussion suggested "string.h" should be renameed more review
> > friendly name. probably.

String should be renamed, yes, I'll do that.

> Hmm, we'd better review files under tools/utils/include too. :(
> (not sure why we have those files, because some files includes
> headers from original include directory, as like as
> "../../include/linux/blahblah.h")

To share code with the kernel (rbtree.[ch], list.h).

- Arnaldo


\
 
 \ /
  Last update: 2010-03-26 19:29    [W:0.629 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site