lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] X86: Optimise fls(), ffs() and fls64()
On Fri, Mar 26, 2010 at 10:45:05AM -0700, Linus Torvalds wrote:

> I went back and checked the old Intel 386 docs from -92 or something, and
> it was "undefined" in there too. So at least Intel seems to have been very
> consistent on this.
>
> That said, maybe all implementations actually do the "don't touch" thing.
>
> But I do have this memory of us doing this ten+ years ago, though, and
> having to check the ZF after all. Which is why I reacted to the patch in
> the first place and checked the documentation.

My trusty old 486 book [1] in the remarks about the BSF instruction:

"The documentation on the 80386 and 80486 states that op1 is undefined if
op2 is 0. In reality the 80386 will leave the value in op1 unchanged.
The first versions of the 80486 will change op1 to an undefined value.
Later version again will leave it unchanged."

[1] Die Intel Familie in German language, by Robert Hummel, 1992


\
 
 \ /
  Last update: 2010-03-26 19:01    [from the cache]
©2003-2011 Jasper Spaans