Messages in this thread | | | Date | Thu, 25 Mar 2010 13:19:29 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c |
| |
Hello.
Russell King - ARM Linux wrote:
>> - debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n", >> - (state->csc_mask==0)?"<NONE> ":"", >> - (state->csc_mask&SS_DETECT)?"DETECT ":"", >> - (state->csc_mask&SS_READY)?"READY ":"", >> - (state->csc_mask&SS_BATDEAD)?"BATDEAD ":"", >> - (state->csc_mask&SS_BATWARN)?"BATWARN ":"", >> - (state->csc_mask&SS_STSCHG)?"STSCHG ":"", >> - (state->flags==0)?"<NONE> ":"", >> - (state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"", >> - (state->flags&SS_IOCARD)?"IOCARD ":"", >> - (state->flags&SS_RESET)?"RESET ":"", >> - (state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"", >> - (state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"", >> + debug(skt, 2, "mask: %s%s%s%s%s%s " >> + "flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n", >> > > NAK. Breaking kernel messages across multiple lines makes them impossible > to grep for. checkpatch.pl is wrong on this one. >
I'd disagree in this case. Anybody will hardly grep for "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%s".
WBR, Sergei
| |