Messages in this thread | | | Date | Fri, 26 Mar 2010 09:54:31 +0900 | From | Joonyoung Shim <> | Subject | Re: [PATCH v2] PL330: Add PL330 DMA controller driver |
| |
On 3/26/2010 7:27 AM, jassi brar wrote: > On Fri, Mar 26, 2010 at 12:13 AM, Dan Williams <dan.j.williams@intel.com> wrote: >> jassi brar wrote: >>>> Perhaps Joonyoung can simply port over the stuff >>>> you need to this driver if you show your code. >>> Having worked on Samsung SoCs(with PL330 DMAC) based products, I would be >>> _very_ surprised if any user found this implementation useful. >>> Let alone testing, this implementation can't even explain usability >>> for fast peripherals >>> with shallow FIFOs. I didn't give feedback for this patch because I am >>> not sure if this >>> is the right way to go at all. >> This is the wrong attitude. 혻If it were not for a simple oversight >> Joonyoung's driver would already be upstream for the past two kernel >> releases. 혻So you need to work together to improve that driver to >> incorporate what you need. > Nothing wrong in attitude here. > Giving feedback on the code only comes after one is convinced with the > overall approach taken. The last time I raised the PL330 driver issue, > most people were not enthusiastic with this drivers/dma/ approach. > I wasn't active mainline discussions when the driver was originally > submitted a few months ago. > And now my replies are not very 'polite' because theres a lot going on > in the background that people in public threads don't know about. > > >> It sounds like you just need to add an extension for the arch specific dma >> api. > I actually plan more than that. > Apart from inefficient design, JoonYoung's driver has made some fatal > assumptions > about PL330, which will result in DMA aborts if used with SoCs that implement > configuration of PL330 that is very different from Samsung SoCs' > Of course, I address all such issues that I can think of, in my implementation. >
I can wait your implementation and wonder what is the issue also.
I welcome you try other design and want better driver is committed at mainline kernel too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |