Messages in this thread |  | | | Date | Fri, 26 Mar 2010 07:36:08 +0900 | | Subject | Re: [PATCH v2] PL330: Add PL330 DMA controller driver | | From | jassi brar <> |
| |
On Fri, Mar 26, 2010 at 12:20 AM, Linus Walleij <linus.ml.walleij@gmail.com> wrote: > 2010/3/25 jassi brar <jassisinghbrar@gmail.com>: >> And if this patch is accepted, there >> _will_ exist two copies of the PL330 driver -- one in drivers/dma/pl330_dmac.c >> and another in arch/arm/plat-samsung/. Only the former will be lying unused >> until some other SoC vendor decided to use PL330, because S3C has come too >> long a way to change its drivers to driver/dma/ API and modify DMA >> drivers for every SoC. > > What's wrong with merging them later then? Refactoring FTW. The amount of code that will be modified or taken out of drivers/dma/pl330_dmac will so much that I will be left only with constrained data structures in the file to do tricks to make it work with the PL330 engine driver. I am not very keen on authoring the driver/dma/ driver but neither am I interested in having to cleanup someone else' code.
>> I have the pl330-core part almost ready, but i need time to implement >> some _testable_ >> implementation of the scheme. If maintainers want to see structure of >> my code, I can >> share it too, but I think I pretty much made it clear. > > Why not just post it on the list? I'm curious! Since I'm working on a PrimeCell > DMA API I would love to look at PrimeCell DMA engine drivers. I'll post in a day or two when the PL330 core driver takes come shape closer to what it is supposed to look. That will help me getting suggestions for improvement, i hope.
regards.
|  |