lkml.org 
[lkml]   [2010]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] resource: shared I/O region support
> Always fun reviewing your own code ;-)
>
> New patch attached.
>
> One question though. I did some reading in
> Documentation/memory-barriers.txt and think it is correct *not* to call
> set_current_state(TASK_INTERRUPTIBLE) after schedule() finishes. Could
> you confirm or deny that?

After the schedule() returns we will be in TASK_RUNNING which is where we
want to be ...


> + if (res->flags & IORESOURCE_MUXED)
> + wake_up(&muxed_resource_wait);
> kfree(res);
> return;

And you'll want a

Signed-off-by: Alan Cox <alan@linux.intel.com>


> }


--
--
"Alan, I'm getting a bit worried about you."
-- Linus Torvalds


\
 
 \ /
  Last update: 2010-03-25 19:17    [W:0.259 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site