Messages in this thread | | | Date | Thu, 25 Mar 2010 18:16:33 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 1/3] resource: shared I/O region support |
| |
> Always fun reviewing your own code ;-) > > New patch attached. > > One question though. I did some reading in > Documentation/memory-barriers.txt and think it is correct *not* to call > set_current_state(TASK_INTERRUPTIBLE) after schedule() finishes. Could > you confirm or deny that?
After the schedule() returns we will be in TASK_RUNNING which is where we want to be ...
> + if (res->flags & IORESOURCE_MUXED) > + wake_up(&muxed_resource_wait); > kfree(res); > return;
And you'll want a
Signed-off-by: Alan Cox <alan@linux.intel.com>
> }
-- -- "Alan, I'm getting a bit worried about you." -- Linus Torvalds
| |