lkml.org 
[lkml]   [2010]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tpmdd-devel] [PATCH] TPM: Provide a tpm_tis OF driver
From
Date
Just a minor comment

On Tue, 2010-03-09 at 13:01 -0700, Jason Gunthorpe wrote:

> @@ -703,7 +747,17 @@ static int __init init_tis(void)
> return rc;
> }
>
> - return pnp_register_driver(&tis_pnp_driver);
> +#ifdef CONFIG_OF
> + rc = of_register_platform_driver(&tis_of_driver);
> + if (rc)
> + return rc;
> +#endif
> +#ifdef CONFIG_PNP
> + rc = pnp_register_driver(&tis_pnp_driver);
> + if (rc)
> + return rc;
> +#endif
> + return 0;
> }
>

Why not

+#ifdef CONFIG_OF
+ return of_register_platform_driver(&tis_of_driver);
+#elif CONFIG_PNP
+ return pnp_register_driver(&tis_pnp_driver);
+#endif

?

Other than this it looks nice.

Acked-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>


Thanks,
Rajiv



\
 
 \ /
  Last update: 2010-03-25 05:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site