Messages in this thread | | | Date | Thu, 25 Mar 2010 15:45:28 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] cfq-iosched: Do not merge queues of BE and IDLE classes |
| |
On Wed, Mar 24 2010, Divyesh Shah wrote: > even if they are found to be co-operating. > > The prio_trees do not have any IDLE cfqqs on them. cfq_close_cooperator() > is called from cfq_select_queue() and cfq_completed_request(). The latter > ensures that the close cooperator code does not get invoked if the current > cfqq is of class IDLE but the former doesn't seem to have any such checks. > So an IDLE cfqq may get merged with a BE cfqq from the same group which > should be avoided.
Thanks, applied.
-- Jens Axboe
| |