Messages in this thread | | | Date | Thu, 25 Mar 2010 12:24:38 +0100 | From | Samuel Ortiz <> | Subject | Re: [patch] mfd: off by one calculating size |
| |
Hi Dan,
On Mon, Mar 22, 2010 at 03:12:42PM +0300, Dan Carpenter wrote: > I'm pretty sure that it should be + 1 here. It's an off by one, because > we start counting at zero. Thanks Dan, patch applied to my for-next branch.
Cheers, Samuel.
> Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Found by a static checker and untested. Please review carefully. > > diff --git a/drivers/mfd/timberdale.h b/drivers/mfd/timberdale.h > index 8d27ffa..902c451 100644 > --- a/drivers/mfd/timberdale.h > +++ b/drivers/mfd/timberdale.h > @@ -66,7 +66,7 @@ > > #define CHIPCTLOFFSET 0x800 > #define CHIPCTLEND 0x8ff > -#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET) > +#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET + 1) > > #define INTCOFFSET 0xc00 > #define INTCEND 0xfff
-- Intel Open Source Technology Centre http://oss.intel.com/
| |