lkml.org 
[lkml]   [2010]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
    On Wed, Mar 24, 2010 at 08:04:58PM -0300, Marcelo Roberto Jimenez wrote:
    > - debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n",
    > - (state->csc_mask==0)?"<NONE> ":"",
    > - (state->csc_mask&SS_DETECT)?"DETECT ":"",
    > - (state->csc_mask&SS_READY)?"READY ":"",
    > - (state->csc_mask&SS_BATDEAD)?"BATDEAD ":"",
    > - (state->csc_mask&SS_BATWARN)?"BATWARN ":"",
    > - (state->csc_mask&SS_STSCHG)?"STSCHG ":"",
    > - (state->flags==0)?"<NONE> ":"",
    > - (state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"",
    > - (state->flags&SS_IOCARD)?"IOCARD ":"",
    > - (state->flags&SS_RESET)?"RESET ":"",
    > - (state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"",
    > - (state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"",
    > + debug(skt, 2, "mask: %s%s%s%s%s%s "
    > + "flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n",

    NAK. Breaking kernel messages across multiple lines makes them impossible
    to grep for. checkpatch.pl is wrong on this one.


    \
     
     \ /
      Last update: 2010-03-25 00:11    [W:0.021 / U:90.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site