Messages in this thread | | | Subject | Re: [PATCH 2/6] move_task_off_dead_cpu: take rq->lock around select_fallback_rq() | From | Peter Zijlstra <> | Date | Wed, 24 Mar 2010 17:17:02 +0100 |
| |
On Wed, 2010-03-24 at 17:07 +0100, Oleg Nesterov wrote: > On 03/24, Peter Zijlstra wrote: > > > > On Mon, 2010-03-15 at 10:10 +0100, Oleg Nesterov wrote: > > > static void move_task_off_dead_cpu(int dead_cpu, struct task_struct *p) > > > { > > > + struct rq *rq = cpu_rq(dead_cpu); > > > + int needs_cpu, dest_cpu; > > > + unsigned long flags; > > > again: > > > + local_irq_save(flags); > > > + > > > + raw_spin_lock(&rq->lock); > > > + needs_cpu = (task_cpu(p) == dead_cpu) && (p->state != TASK_WAKING); > > > > ^ > > kernel/sched.c:5445: warning: ‘dest_cpu’ may be used uninitialized in this function > > Hmm. looks like my gcc is more friendly...
Hrm, that and I'm apparently unable to read, it said dest_cpu, not dead_cpu.. a well, I'll slam an __maybe_unused in.
> OK. certainly I'll send the updated patch, if this series passes > your review otherwise.
Yeah, you made a few good points in 0/6, am now staring at the code on how to close those holes, hope to post something sensible soon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |