lkml.org 
[lkml]   [2010]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -v4 00/08] use lmb with x86
From
Date
On Wed, 2010-03-24 at 11:48 +0100, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > new early_res is lmb extension. and it could be used to replace bootmem.
>
> Why not do what we suggested: extend lmb.c to also offer the
> early_res-equivalent functionality, and remove kernel/early_res.c and move
> lib/lmb.c to mm/lmb.c?
>
> We dont want two facilities (early_res and lmb) really ...

Exactly.

This series seems to leave us with kernel/early_res.c (which should
never have moved out of arch/x86 AFAICS) - as well as using some of
lmb.c.

It doesn't compile on powerpc, because early_res.c is looking for
find_fw_memmap_area() which is still under arch/x86.

And sprinkling CONFIG_NO_BOOTMEM everywhere is getting a bit gross. I
notice that's already happened to mm/(bootmem|page_alloc).c but
propagating it further is not nice.

cheers
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-03-24 12:43    [W:0.235 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site