lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips
On Tue, Mar 23, 2010 at 07:24:50PM -0700, Marcel Holtmann wrote:
> > +#define N_TI_WL 20 /* for TI's WL connectivity chips */
> >
> > /*
> > * This character is the same as _POSIX_VDISABLE: it cannot be used as
>
> why is this even targeting staging. I prefer if we have proper review
> cycles and get this reviewed this way. This looks like more a shortcut
> to get things into the kernel than actually spending the effort to clean
> things up.
>
> If this would be just a driver, I wouldn't care, but it tries to assign
> official numbers for a line discipline and clearly collides with other
> peoples work that are going the proper upstream review cycles.
>
> Greg, I would like to see the rule that if it touches files outside of
> drivers/staging/ then it is not eligible for staging.

That is a rule already :)

See my complaint about this a few minutes ago.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-03-24 03:53    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site