lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2] cx231xx: card->driver "Conexant cx231xx Audio" too long
    At Mon, 22 Mar 2010 18:39:09 +0300,
    Dan Carpenter wrote:
    >
    > card->driver is 15 characters and a NULL, the original code could
    > cause a buffer overflow.
    >
    > Signed-off-by: Dan Carpenter <error27@gmail.com>
    > ---
    > In version 2, I used a better name that Takashi Iwai suggested.

    Acked-by: Takashi Iwai <tiwai@suse.de>

    Could you fix em28xx in the same way, too?


    thanks,

    Takashi

    > diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c
    > index 7793d60..7cae95a 100644
    > --- a/drivers/media/video/cx231xx/cx231xx-audio.c
    > +++ b/drivers/media/video/cx231xx/cx231xx-audio.c
    > @@ -495,7 +495,7 @@ static int cx231xx_audio_init(struct cx231xx *dev)
    > pcm->info_flags = 0;
    > pcm->private_data = dev;
    > strcpy(pcm->name, "Conexant cx231xx Capture");
    > - strcpy(card->driver, "Conexant cx231xx Audio");
    > + strcpy(card->driver, "Cx231xx-Audio");
    > strcpy(card->shortname, "Cx231xx Audio");
    > strcpy(card->longname, "Conexant cx231xx Audio");
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >


    \
     
     \ /
      Last update: 2010-03-23 08:01    [W:0.023 / U:0.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site