| | Date | Tue, 23 Mar 2010 18:32:28 +0000 | | From | Mel Gorman <> | | Subject | Re: [PATCH 08/11] Add /proc trigger for memory compaction |
| |
On Tue, Mar 23, 2010 at 01:25:47PM -0500, Christoph Lameter wrote: > On Tue, 23 Mar 2010, Mel Gorman wrote: > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index 0d2e8aa..faa9b53 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -346,3 +347,63 @@ static int compact_zone(struct zone *zone, struct compact_control *cc) > > return ret; > > } > > > > +/* Compact all zones within a node */ > > +static int compact_node(int nid) > > +{ > > + int zoneid; > > + pg_data_t *pgdat; > > + struct zone *zone; > > + > > + if (nid < 0 || nid > nr_node_ids || !node_online(nid)) > > Must be nid >= nr_node_ids. >
Oops, correct. It should be "impossible" to supply an incorrect nid here but still.
> Otherwise > > Reviewed-by: Christoph Lameter <cl@linux-foundation.org> >
Thanks
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
|