lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] cpufreq: Unify sysfs attribute definition macros
    From: Thomas Renninger <trenn@suse.de>
    Date: Tue, Mar 23, 2010 at 12:07:29PM +0100

    > > +#define define_one_global_ro(_name) \
    > > +static struct global_attr _name = \
    > > +__ATTR(_name, 0444, show_##_name, NULL)
    > > +
    > > +#define define_one_global_rw(_name) \
    > > +static struct global_attr _name = \
    > > +__ATTR(_name, 0644, show_##_name, store_##_name)
    >
    > These sound like too general names in global space.
    > And are unrelated to cpufreq(.h).

    maybe call them cpufreq_define_(global|freq)_* then?

    > Eventually you get them into sysfs.h with another name
    > or just duplicate them?

    Well, struct freq_attr for example is cpufreq-specific attribute,
    AFAICT. So, keeping them in cpufreq.h should be fine, no?

    --
    Regards/Gruss,
    Boris.

    --
    Advanced Micro Devices, Inc.
    Operating Systems Research Center


    \
     
     \ /
      Last update: 2010-03-23 12:45    [W:0.020 / U:92.064 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site