lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] hid: new driver for PicoLCD device
On Sun, Mar 21, 2010 at 05:37:37PM +0100, Bruno Prémont wrote:
> On Sat, 20 March 2010 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > > + usbhid_submit_report(data->hdev, report, USB_DIR_OUT);
> > > + complete_all(&data->ready);
> > > + INIT_COMPLETION(data->ready);
> >
> > Umm, what does this do, exactly?
>
> It wakes up anyone waiting on the completion and then resets the completion
> as otherwise any future attempt to wait on it would succeed immediately.
>

You realize that if you re-initialize the completion right after
signalling it there is a big chance the waiters will miss it (they do
check completion->done flags that you reset right away.

In general completions are suited for something that happens once (a
single request - allocated - processed - signalled) but not for
repeating use.

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-03-22 05:37    [W:0.079 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site