lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateMon, 22 Mar 2010 11:57:42 +0200
SubjectRe: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
FromPekka Enberg <>
On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@coyote.org> wrote:
> On 2010-03-22 08:16, Pekka Enberg wrote:
>> Lars Lindley kirjoitti:
>>> I fixed the checkpatch things except a couple of long lines.
>>> I also removed hungarian notation from the argument names
>>> and some "commented away" code.
>>>
>>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>>
>> Did you check that all these function declarations are actually used?
>> I've spotted plenty of dead code in the past.
>>
> Nope, didn't check that. Just looking at the style now..

Well, based on my experience, you're will do a lot of unnecessary work
on code that's going to get removed because it's not actually used.
That's why I haven't bothered with style cleanups much.

>>> +/*
>>> + * ====================================
>>> + * Interface function declare
>>> + * ====================================
>>> + */
>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
>>
>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
>> see the same thing elsewhere in this patch as well.
>>
> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
> CamelCase alone for now. I can make it like that if you want..

Yes please.


\
 
 \ /
  Last update: 2010-03-22 10:59    [from the cache]
©2003-2010