Messages in this thread | | | Date | Tue, 23 Mar 2010 09:44:56 +0800 | From | Cong Wang <> | Subject | Re: [Patch v2] netpoll: warn when there are spaces in parameters |
| |
Matt Mackall wrote: > On Mon, 2010-03-22 at 04:59 -0400, Amerigo Wang wrote: >> + printk(KERN_INFO "%s: warning: whitespace" >> + "is not allowed\n", np->name); > > Is it a warning or is it info? If it's a warning, then we probably need > to add "netpoll" or whatever to the message so that people who've got a > warning-level threshold will know what it's about. >
If you mean KERN_INFO, yeah, I want to keep it in the same level as other messages around.
Also, I already put "np->name" which will be "netconsole" when we use netconsole.
Thanks.
| |