lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module
On Mon, Mar 22, 2010 at 09:28:25PM +0100, Wolfgang Grandegger wrote:

[ big snip ]

>
> You could even add the tx/rx values for each error message (for both,
> state changes and bus-errors).
>

Ok, with that change, I get the following:

berr-reporting on:

can0 20000088 [8] 00 00 80 19 00 00 08 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 10 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 18 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 20 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 28 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 30 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 38 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 40 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 48 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 50 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 58 00 ERRORFRAME
can0 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 60 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 68 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 70 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 78 00 ERRORFRAME
can0 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 80 00 ERRORFRAME
can0 20000088 [8] 00 00 80 19 00 00 80 00 ERRORFRAME

And now lots more of this last frame repeated, until the controller
decides to stop. Seems fine. It has always done this.

berr-reporting off:

can1 20000004 [8] 00 08 00 00 00 00 60 00 ERRORFRAME
can1 20000004 [8] 00 20 00 00 00 00 80 00 ERRORFRAME


Same as before. Excellent.

> > I haven't heard back from Samuel Ortiz yet about the changes for the mfd
> > layer. Would you like me to send out my latest CAN driver changes, or
> > should I just wait until I hear back?
>
> As you need patch 1/3 anyway, just wait some more time. From my point of
> view the next version of the patch will be OK.
>

Ok, I'll wait a few more days before pinging him again. He's CC'd on all
of these emails anyway. :)

Thanks for all the help,
Ira


\
 
 \ /
  Last update: 2010-03-22 21:53    [W:0.357 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site