Messages in this thread |  | | | Date | Mon, 22 Mar 2010 09:16:25 +0200 | | From | Pekka Enberg <> | | Subject | Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes. |
| |
Lars Lindley kirjoitti: > I fixed the checkpatch things except a couple of long lines. > I also removed hungarian notation from the argument names > and some "commented away" code. > > Signed-off-by: Lars Lindley <lindley@coyote.org>
Did you check that all these function declarations are actually used? I've spotted plenty of dead code in the past.
> +/* > + * ==================================== > + * Interface function declare > + * ==================================== > + */ > +unsigned char Wb35Reg_initial(struct hw_data *HwData);
Lets avoid CamelCase for the arguments so "hw_data" here, for example. I see the same thing elsewhere in this patch as well.
|  |