Messages in this thread | | | Date | Mon, 22 Mar 2010 11:13:27 -0700 | From | "Darrick J. Wong" <> | Subject | Re: [patch] power_meter: acpi_device_class "power_meter_resource" too long |
| |
On Fri, Mar 19, 2010 at 02:49:20PM +0300, Dan Carpenter wrote: > acpi_device_class can only be 19 characters and a NULL terminator. > > The current code has a buffer overflow in acpi_power_meter_add(): > strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS); > > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Feel free to change the name to anything you like.
How hard would it be to increase the size of that buffer?
(Or, is there a need to have "_resource" in that string at all?)
--D
| |