Messages in this thread |  | | | Date | Mon, 22 Mar 2010 16:27:05 +0100 (CET) | | From | Jiri Kosina <> | | Subject | Re: [PATCH 2/2] Updated hid_blacklist, reformatted code and removed unused variable |
| |
On Mon, 22 Mar 2010, Stefan Achatz wrote:
> > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > index 368fbb0..dbd6fb8 100644 > > > --- a/drivers/hid/hid-core.c > > > +++ b/drivers/hid/hid-core.c > > > @@ -1346,6 +1346,7 @@ static const struct hid_device_id hid_blacklist[] = > > > { { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, > > > USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) }, { > > > HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) > > > }, { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, > > > USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN) }, + { > > > HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) }, { > > > HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) }, > > > { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) > > > }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, > > > USB_DEVICE_ID_SONY_PS3_CONTROLLER) }, > > > > Thanks for the fix. I only wonder how well has the driver been tested, as > > without this change it couldn't get to operate the device at all ... ? > > > > Thanks, > > Hi, > > As most testing was done with external module compilation on different kernel > versions with generic hid compiled as internal or as module I have a script > that uses the drivers sysfs bind/unbind funtionality to switch from generic > hid to kone driver. Thats issued via udev and was active all the time.
OK, thanks.
I will fold the patches into one, and I will also make the driver independent on CONFIG_EMBEDDED, to be comopatible with other HID drivers which are not simple quirks, but rather full, stand-alone HID device drivers.
Thanks,
-- Jiri Kosina SUSE Labs, Novell Inc.
|  |