lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v2] pcrypt: handle crypto_get_attr_type() errors
On Mon, Mar 22, 2010 at 04:53:19PM +0300, Dan Carpenter wrote:
>
> -static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
> +static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb,
> + struct crypto_attr_type *algt)
> {
> struct crypto_instance *inst;
> struct crypto_alg *alg;
> - struct crypto_attr_type *algt;
> -
> - algt = crypto_get_attr_type(tb);
>
> alg = crypto_get_attr_alg(tb, algt->type,
> (algt->mask & CRYPTO_ALG_TYPE_MASK));
> @@ -365,7 +363,7 @@ static struct crypto_instance *pcrypt_alloc(struct rtattr **tb)
>
> switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) {
> case CRYPTO_ALG_TYPE_AEAD:
> - return pcrypt_alloc_aead(tb);
> + return pcrypt_alloc_aead(tb, algt);
> }
>

I thought about passing the type and mask values separately to
pcrypt_alloc_aead, like type and mask values are passed to
crypto_get_attr_alg. This is the usual way to do this in the
crypto layer.

Thanks,

Steffen


\
 
 \ /
  Last update: 2010-03-22 15:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site