lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] oprofile: remove double ring buffering
On Sat, Mar 20, 2010 at 12:45:20AM -0400, Steven Rostedt wrote:
> On Sat, 2010-03-20 at 01:03 +0100, Andi Kleen wrote:
> > [This is currently being tested if it fixes the excessive samples
> > dropping I have been complaining about for some time. Still wanted
> > to post the patch for review.]
> >
> > commit 49e66e8ab54f1114237e6dc24dc32ac912870c41
> > Author: Andi Kleen <ak@linux.intel.com>
> > Date: Fri Mar 19 21:03:48 2010 +0100
> >
> > oprofile: remove double ring buffering
> >
> > oprofile used a double buffer scheme for its cpu event buffer
> > to avoid races on reading with the old lock less ring buffer.
>
> The old ring buffer was not lockless, hence the need for two ring
> buffers because of NMIs. The new ring buffer is lockless.

Thanks. Description fixed.

-Andi


\
 
 \ /
  Last update: 2010-03-20 06:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site