lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 09/24] macintosh: fix dangling pointers
    Fix I2C-drivers which missed setting clientdata to NULL before freeing the
    structure it points to. Also fix drivers which do this _after_ the structure
    was freed already.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Cc: Colin Leroy <colin@colino.net>
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    ---

    Found using coccinelle, then reviewed. Full patchset is available via
    kernel-janitors, linux-i2c, and LKML.
    ---
    drivers/macintosh/therm_adt746x.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/macintosh/therm_adt746x.c b/drivers/macintosh/therm_adt746x.c
    index c42eeb4..16d82f1 100644
    --- a/drivers/macintosh/therm_adt746x.c
    +++ b/drivers/macintosh/therm_adt746x.c
    @@ -182,6 +182,7 @@ remove_thermostat(struct i2c_client *client)

    thermostat = NULL;

    + i2c_set_clientdata(client, NULL);
    kfree(th);

    return 0;
    @@ -399,6 +400,7 @@ static int probe_thermostat(struct i2c_client *client,
    rc = read_reg(th, CONFIG_REG);
    if (rc < 0) {
    dev_err(&client->dev, "Thermostat failed to read config!\n");
    + i2c_set_clientdata(client, NULL);
    kfree(th);
    return -ENODEV;
    }
    --
    1.7.0


    \
     
     \ /
      Last update: 2010-03-20 15:17    [W:0.030 / U:0.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site