lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Wireless: Make cfg80211_dev_rename() check sscanf return value in net/wireless/core.c
From
Date
On Sat, 2010-03-20 at 12:53 +0800, wzt.wzt@gmail.com wrote:
> Make cfg80211_dev_rename() check sscanf return value.
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
>
> ---
> net/wireless/core.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/core.c b/net/wireless/core.c
> index 80afacd..8e815b4 100644
> --- a/net/wireless/core.c
> +++ b/net/wireless/core.c
> @@ -146,7 +146,9 @@ int cfg80211_dev_rename(struct cfg80211_registered_device *rdev,
> int idx, taken = -1, result, digits;
>
> /* prohibit calling the thing phy%d when %d is not its number */
> - sscanf(newname, PHY_NAME "%d%n", &idx, &taken);
> + if (sscanf(newname, PHY_NAME "%d%n", &idx, &taken) != 2)
> + return -EINVAL;
> +

Umm, no, your patch breaks it completely. Look at the logic again.

johannes



\
 
 \ /
  Last update: 2010-03-20 08:45    [W:2.170 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site