Messages in this thread Patch in this message | | | Subject | Re: [PATCH -v6] x86: do not free zero sized per cpu areas | From | Ian Campbell <> | Date | Sat, 20 Mar 2010 07:12:08 +0000 |
| |
Looks good to me, thanks Yinghai.
On Sat, 2010-03-20 at 06:38 +0000, Yinghai Lu wrote: > From: Ian Campbell <ian.campbell@citrix.com> > > This avoids an infinite loop in free_early_partial(). > > Add a warning to free_early_partial to catch future problems. > > -v5: put back start > end back into WARN_ONCE() > -v6: use one line for if according to linus > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@elte.hu> > --- > kernel/early_res.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: linux-2.6/kernel/early_res.c > =================================================================== > --- linux-2.6.orig/kernel/early_res.c > +++ linux-2.6/kernel/early_res.c > @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start > struct early_res *r; > int i; > > + if (start == end) > + return; > + > + if (WARN_ONCE(start > end, "free_early_partial: wrong range [%#llx, %#llx]\n", start, end)) > + return; > + > try_next: > i = find_overlapped_early(start, end); > if (i >= max_early_res)
| |