lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ceph-devel] [patch] ceph: cleanup: remove dead code
On Sat, 20 Mar 2010, Dan Carpenter wrote:

> "xattr" is never NULL here. We took care of that in the previous
> if statement block.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index 37d6ce6..65b0e9b 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -185,12 +185,6 @@ static int __set_xattr(struct ceph_inode_info *ci,
> ci->i_xattrs.names_size -= xattr->name_len;
> ci->i_xattrs.vals_size -= xattr->val_len;
> }
> - if (!xattr) {
> - pr_err("__set_xattr ENOMEM on %p %llx.%llx xattr %s=%s\n",
> - &ci->vfs_inode, ceph_vinop(&ci->vfs_inode), name,
> - xattr->val);
> - return -ENOMEM;
> - }
> ci->i_xattrs.names_size += name_len;
> ci->i_xattrs.vals_size += val_len;
> if (val)

Applied, thanks!
sage


\
 
 \ /
  Last update: 2010-03-21 05:01    [W:0.023 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site