Messages in this thread | | | Date | Sat, 20 Mar 2010 20:59:23 -0700 (PDT) | From | Sage Weil <> | Subject | Re: [ceph-devel] bug report: ceph: && vs || |
| |
On Sat, 20 Mar 2010, Dan Carpenter wrote: > > > 1772 /* correct session? */ > 1773 if (!req->r_session && req->r_session != session) { > > Is this supposed to || here? We know "session" is non-NULL at > the point because we already dereferenced it. If "req->r_session" > is null then the second condition is always true. > > Also we dereference "req->r_session" later on without checking.
Yeah, that check is clearly wrong. A
if (req->r_session != session) {
is sufficient because the passed session is always non-NULL. Applied a fix.
Thanks- sage
| |