lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH
    On Sat, Mar 20, 2010 at 05:11:19PM +0100, Bruno Prémont wrote:
    > The PicoLCD device has a small amount of EEPROM and also provides
    > access to its FLASH where firmware and splash image are saved.
    > In flasher mode FLASH access is the only active feature.
    >
    > Give read/write access to both via debugfs files.
    >

    It looks you are allowing multiple users access to these files. What
    will happen if 2 processes try to write EEPROM at the same time?

    > +
    > +static inline int picolcd_init_devfs(struct picolcd_data *data,
    > + struct hid_report *eeprom_r, struct hid_report *eeprom_w,
    > + struct hid_report *flash_r, struct hid_report *flash_w,
    > + struct hid_report *reset)
    > +{

    I don't think this should be forced inline.

    Thanks.

    --
    Dmitry
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-21 04:11    [W:0.023 / U:1.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site