Messages in this thread | | | Date | Sun, 21 Mar 2010 02:59:26 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH 06/24] input/keyboard: fix dangling pointers |
| |
Hello Dmitry,
On Sat, Mar 20, 2010 at 12:20:07PM -0700, Dmitry Torokhov wrote: > Hi Wolfram, > > On Sat, Mar 20, 2010 at 03:12:47PM +0100, Wolfram Sang wrote: > > Fix I2C-drivers which missed setting clientdata to NULL before freeing the > > structure it points to. Also fix drivers which do this _after_ the structure > > was freed already. > > > > I am not sure if setting clientdata to NULL before freeing the data is > that important; we really want to be sure that we don't leave clientdata > dangling when we finish unbinding the driver. If there are another > thread the change will not really help the problem of accessing > non-existing client data.
I agree it won't matter in practice. Jean and I concluded it is better style, though (http://comments.gmane.org/gmane.linux.drivers.i2c/5392). Still, I will not insist and leave it up the subsystem maintainers, of course. I also won't check for that case again in the future.
> I will apply lm8323 portion of the patch but leave qt2160 as is.
Thanks!
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |