| Date | Sat, 20 Mar 2010 11:50:06 -0400 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v1 1/10] Move Macro W to insn.h |
| |
Srikar Dronamraju wrote: > Move Macro W to asm/insn.h > > Macro W used to know if the instructions are valid for > user-space/kernel space. This macro is used by kprobes and > user_bkpt. (i.e user space breakpoint assistance layer.) So moving it > to a common header file asm/insn.h.
Hmm, I don't think this shortest macro name is good to expose commonly... And also, since we already have inat (instruction attribute) table, we'd better expand an inat bit to indicate which instruction can be probed/boosted.
Thank you,
-- Masami Hiramatsu e-mail: mhiramat@redhat.com
|