lkml.org 
[lkml]   [2010]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 23/24] video/matrox: fix dangling pointers
    Fix I2C-drivers which missed setting clientdata to NULL before freeing the
    structure it points to. Also fix drivers which do this _after_ the structure
    was freed already.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
    ---

    Found using coccinelle, then reviewed. Full patchset is available via
    kernel-janitors, linux-i2c, and LKML.
    ---
    drivers/video/matrox/matroxfb_maven.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
    index 91af915..e7b0ec3 100644
    --- a/drivers/video/matrox/matroxfb_maven.c
    +++ b/drivers/video/matrox/matroxfb_maven.c
    @@ -1254,6 +1254,7 @@ static int maven_probe(struct i2c_client *client,
    goto ERROR4;
    return 0;
    ERROR4:;
    + i2c_set_clientdata(client, NULL);
    kfree(data);
    ERROR0:;
    return err;
    --
    1.7.0


    \
     
     \ /
      Last update: 2010-03-20 15:19    [W:0.019 / U:2.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site