Messages in this thread | | | Date | Tue, 2 Mar 2010 09:31:13 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [tip:x86/irq] x86: apic: Fix mismerge, add arch_probe_nr_irqs() again |
| |
On Mon, 1 Mar 2010, Eric W. Biederman wrote: > Ian Campbell <ijc@hellion.org.uk> writes: > > On Mon, 2010-03-01 at 10:34 -0800, Eric W. Biederman wrote: > It is going to take a bit but our next big step for the irq methods > is to make them all take struct irq_desc pointers instead of unsigned > int irq, so we don't have to repeat the lookups.
That should hit 2.6.35.
> >> - Xen has an array irq_info[NR_IRQS] one of the last static arrays > >> sized at NR_IRQs in the entire kernel. > > > > Hopefully the same info as is in that array could (and indeed should) be > > instead stored in irq_desc->chip_data. Would you object to > > arch_init_copy_chip_data and arch_free_chip_data becoming function > > pointers within the struct irq_chip? > > No objections. Now that I see those methods it looks like they always > should have been in irq_chip.
Agreed.
Thanks,
tglx
| |