lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: dream: pmem: fix some code style issues
On Mon 2010-03-01 20:50:15, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some code style issues like some braces {} deleted becouse
> are not necessary for a single statement blocks and to include KERN_
> facility level in the printk() functions.

Most of patch is good, but...

> @@ -936,8 +934,8 @@ int pmem_remap(struct pmem_region *region, struct file *file,
> if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
> !PMEM_IS_PAGE_ALIGNED(region->len))) {
> #if PMEM_DEBUG
> - printk("pmem: request for unaligned pmem suballocation "
> - "%lx %lx\n", region->offset, region->len);
> + printk(KERN_ERR "pmem: request for unaligned pmem "
> + "suballocation %lx %lx\n", region->offset, region->len);
> #endif
> return -EINVAL;
> }

This is strange. If it is debuging print, should it be KERN_DEBUG? And
we have nice dev_dbg macros for just that, so that ifdef is not
neccessarry.

> @@ -1087,8 +1085,10 @@ static long pmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> region.offset = pmem_start_addr(id, data);
> region.len = pmem_len(id, data);
> }
> - printk(KERN_INFO "pmem: request for physical address of pmem region "
> - "from process %d.\n", current->pid);
> + printk(KERN_INFO "pmem: request for physical address "
> + "of pmem region from process %d.\n",
> + current->pid);
> +

And this gets code worse, not better.

(Feel free to send all the other hunks with my ACK.)
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2010-03-02 06:25    [W:0.042 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site