lkml.org 
[lkml]   [2010]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/12] syscalls: add new COMPAT_SYSCALL_DEFINE#N() macro
On Mon, Mar 01, 2010 at 04:05:22PM -0500, Jason Baron wrote:
> On Sun, Feb 28, 2010 at 11:09:02AM +0100, Heiko Carstens wrote:
> > For architectures which select CONFIG_HAVE_SYSCALL_WRAPPERS this adds
> > unnecessary sign extension code to each compat syscall.
> > On the other hand we could get rid partly of the arch specific sign extension
> > code but that would need some other changes before as well.
> > For example this one:
> >
> > asmlinkage long compat_sys_gettimeofday(struct compat_timeval __user *tv,
> > struct timezone __user *tz)
> >
> > should be converted to a function which takes two compat_uptr_t's and let
> > the syscall code itself do the proper pointer conversion (compat_ptr()).
> >
> > Besides that the syscall alias names for these compat calls do look a
> > bit strange:
> >
> > 000000000008b57c T SyScompat_sys_adjtimex
> > 000000000008b57c T compat_sys_adjtimex
> >
> > That needs to be fixed as well.
> > Or simply add a 1:1 wrapper independent of CONFIG_HAVE_SYSCALL_WRAPPERS.
>
> ok, the later suggestion seems simpler. Below I've re-spun patch #6 and
> #8. how do they look?

Looks good to me! :)


\
 
 \ /
  Last update: 2010-03-02 07:43    [W:0.039 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site