lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v4] x86: do not free zero sized per cpu areas


On Fri, 19 Mar 2010, Yinghai Lu wrote:
> +
> + if (start > end) {
> + WARN_ONCE(1,
> + "free_early_partial got wrong start/end %#llx/%#llx\n",
> + start, end);
> +
> + return;

This should be written as

if (WARN_ONCE(start > end, "free_early_partial(%#llx/%#llx)\n", start, end))
return;
rather than having a separate conditional.

Linus


\
 
 \ /
  Last update: 2010-03-20 02:07    [from the cache]
©2003-2011 Jasper Spaans