lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] arch/x86/kernel/head_32.S Warning: shift count out of range (32 is not between 0 and 31)
On 03/18/2010 03:08 PM, René Bolldorf wrote:
> Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>
>
> diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
> index 37c3d4b..8bfba5e 100644
> --- a/arch/x86/kernel/head_32.S
> +++ b/arch/x86/kernel/head_32.S
> @@ -62,7 +62,7 @@
>
> /* Enough space to fit pagetables for the low memory linear map */
> MAPPING_BEYOND_END = \
> - PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
> + PAGE_TABLE_SIZE(((1<<31) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
>
> /*
> * Worst-case size of the kernel mapping we need to make:

NAK... this is in fact doubly wrong... the assembler handles this case
just fine -- it's a .S file after all -- and the result is wrong.

If you want to change it change it to 0x100000000.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-03-19 22:47    [W:0.051 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site