lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [LKML] Re: Infinite loop on boot in free_early_partial due to start==end on tip/master
From
Date
On Fri, 2010-03-19 at 21:17 +0000, Yinghai Lu wrote: 
> > index ef6370b..89a3205 100644
> > --- a/arch/x86/kernel/setup_percpu.c
> > +++ b/arch/x86/kernel/setup_percpu.c
> > @@ -140,7 +140,8 @@ static void __init pcpu_fc_free(void *ptr, size_t
> > size)
> > #ifdef CONFIG_NO_BOOTMEM
> > u64 start = __pa(ptr);
> > u64 end = start + size;
> > - free_early_partial(start, end);
> > + if (start < end)
> > + free_early_partial(start, end);
>
> it seems we could remove this line

> Tejun, how this could happen? free zero range ?

I was seeing start==end although I never fully understood why. It
happened somewhere within pcpu_embed_first_chunk and/or
pcpu_build_alloc_info. My original posting (in
https://patchwork.kernel.org/patch/83756/) has some speculation.

Ian.

>
> YH
>
> > #else
> > free_bootmem(__pa(ptr), size);
> > #endif
> > diff --git a/kernel/early_res.c b/kernel/early_res.c
> > index 3cb2c66..f3a861b 100644
> > --- a/kernel/early_res.c
> > +++ b/kernel/early_res.c
> > @@ -333,6 +333,11 @@ void __init free_early_partial(u64 start, u64 end)
> > struct early_res *r;
> > int i;
> >
> > + if (WARN_ONCE(start >= end,
> > + "free_early_partial got wrong start/end
> > %#llx/%#llx\n",
> > + start, end))
> > + return;
> > +
> > try_next:
> > i = find_overlapped_early(start, end);
> > if (i >= max_early_res)
> >




\
 
 \ /
  Last update: 2010-03-19 22:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site