lkml.org 
[lkml]   [2010]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Document Linux's circular buffering capabilities
From
Date
On Mar 15, 2010, at 8:43 AM, Stefan Richter wrote:

> David Howells wrote:
>> How about adding a bit:
>>
>> Note the use of ACCESS_ONCE() in both algorithms to read the opposition index.
>> This prevents the compiler from discarding and reloading its cached value -
>> -which some compilers will do across smp_read_barrier_depends().
>> +which some compilers will do across smp_read_barrier_depends(). This isn't
>> +strictly needed if you can be sure that the opposition index will _only_ be
>> +used the once.
>
> Yes, thanks. (The last "the" is superfluous.)

Maybe it would be clearer to change "the once" to "the one time" or "that one time". "the once" reads too much like an error which may lead to it being "corrected" some day, most likely then losing the intended meaning.

--
Mark Rustad, MRustad@gmail.com



\
 
 \ /
  Last update: 2010-03-19 18:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site