Messages in this thread | | | Subject | Re: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free | From | Darren Jenkins <> | Date | Thu, 18 Mar 2010 19:46:48 +1100 |
| |
On Thu, Mar 18, 2010 at 9:10 AM, Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> wrote:
> If krealloc() fails to aallocate a new pointer, the old block is > unmodified, so by doing this you are leaking a buffer allocation.
It seems you are right. So now understanding correctly how krealloc() works I can see that the double kfree() can only actually happen if the el_size parameter to i2400m_zrealloc_2x() is zero, and it isn't at the two call sites.
So this was a false positive and I am sorry for the noise.
Darren J.
| |